Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fast_check): better property output #416

Merged
merged 7 commits into from
Mar 12, 2024
Merged

fix(fast_check): better property output #416

merged 7 commits into from
Mar 12, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Mar 12, 2024 •
edited
Loading

Uses the declare keyword more when able because it supresses type checking errors like:

Property 'stateChangeHandler' will overwrite the base property in 'ClientAbstract'. If this is intentional, add an initializer. Otherwise, add a 'declare' modifier or remove the redundant declaration.

@dsherret dsherret marked this pull request as ready for review March 12, 2024 01:34
@dsherret dsherret requested a review from bartlomieju March 12, 2024 01:34
@dsherret dsherret mentioned this pull request Mar 12, 2024
Merged
@dsherret
Copy link
Member Author

I'll merge this tomorrow after additional testing.

@dsherret dsherret merged commit 3224160 into denoland:main Mar 12, 2024
4 checks passed
@dsherret dsherret deleted the fix_properties_fast_check branch March 12, 2024 14:33
dsherret added a commit to denoland/deno that referenced this pull request Mar 12, 2024
@dsherret
fix(slow-types): improved exports tracing and infer type literals in …
c10d96c 
…as exprs (#22849)

Several fixes in deno_graph:

* denoland/deno_graph#411
* denoland/deno_graph#413
* denoland/deno_graph#414
* denoland/deno_graph#415
* denoland/deno_graph#416
* denoland/deno_graph#417

Also created https://github.com/denoland/publish_smoke_tests to help
prevent regressions in the future.

Closes #22829
Closes #22819
Closes #22802
nathanwhit pushed a commit to denoland/deno that referenced this pull request Mar 14, 2024
@dsherret @nathanwhit
fix(slow-types): improved exports tracing and infer type literals in …
5b3658f 
…as exprs (#22849)

Several fixes in deno_graph:

* denoland/deno_graph#411
* denoland/deno_graph#413
* denoland/deno_graph#414
* denoland/deno_graph#415
* denoland/deno_graph#416
* denoland/deno_graph#417

Also created https://github.com/denoland/publish_smoke_tests to help
prevent regressions in the future.

Closes #22829
Closes #22819
Closes #22802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju