feat: support importing from jsr via HTTPS specifiers (except for type checking) #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of jsr-io/jsr#322
This allows importing from JSR via HTTPS specifiers as part of the code graph, but will error resolution for the type graph. Additionally, redirecting to a JSR HTTPS specifier from a non-JSR specifier is not yet implemented for this first pass.
The reason we don't support import JSR packages via HTTPS for type checking is because if we allowed importing anywhere in a package, then the entire package becomes part of the public api rather than just the entrypoints, so we'd be back to the same issues with deno.land/x where entire package implementations are being type checked.