Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trace parent classes and interfaces of referenced qualified expressions #465

Merged
merged 5 commits into from
May 2, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented May 2, 2024

We were tracing into a class' static method in this scenario, but not tracing the parent class.

> ../deno/target/debug/deno publish --dry-run
Checking for slow types in the public API...
Check file:///V:/ts-rpc/client.ts
Check file:///V:/ts-rpc/adapters/oak.ts
Simulating publish of @andykais/ts-rpc@0.1.0 with files:
   file:///V:/ts-rpc/.github/workflows/deno.yml (1.01KB)
   file:///V:/ts-rpc/README.md (2.6KB)
   file:///V:/ts-rpc/adapters/mod.ts (2.91KB)
   file:///V:/ts-rpc/adapters/oak.ts (2.32KB)
   file:///V:/ts-rpc/client.ts (7.36KB)
   file:///V:/ts-rpc/deno.jsonc (380B)
   file:///V:/ts-rpc/deno.lock (31.6KB)
   file:///V:/ts-rpc/server.ts (1.89KB)
   file:///V:/ts-rpc/src/contracts.ts (1.41KB)
   file:///V:/ts-rpc/src/errors.ts (4.12KB)
   file:///V:/ts-rpc/src/types.ts (2.17KB)
   file:///V:/ts-rpc/tests/tools/deps.ts (499B)
   file:///V:/ts-rpc/tests/tools/fetch_mock.ts (5.34KB)
   file:///V:/ts-rpc/tests/tools/tools.ts (3.65KB)
   file:///V:/ts-rpc/tests/ts-rpc.test.ts (8.37KB)
Warning Aborting due to --dry-run

For denoland/deno#23658

@dsherret dsherret merged commit e56741b into denoland:main May 2, 2024
4 checks passed
@dsherret dsherret deleted the fix_class_decl_base branch May 2, 2024 17:07
dsherret added a commit to denoland/deno that referenced this pull request May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants