fix(node): change resolution mode based on import construct #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Nov 25, 2024
| @@ -14,7 +14,7 @@ use deno_graph::source::LoadFuture; | |||
| use deno_graph::source::LoadOptions; | |||
| use deno_graph::source::Loader; | |||
| use deno_graph::source::NullFileSystem; | |||
| use deno_graph::source::ResolutionMode; | |||
| use deno_graph::source::ResolutionKind; | |||
There was a problem hiding this comment.
Renamed so that ResolutionMode aligns with TypeScript's wording https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-3.html#stable-support-resolution-mode-in-import-types
dsherret
commented
Nov 25, 2024
tests/specs/graph/cjs/basic.txt
Outdated
There was a problem hiding this comment.
Notice in particular the changes in this file.
dsherret
commented
Nov 25, 2024
src/lib.rs
Outdated
There was a problem hiding this comment.
I outlined a bug with this PR in #80 (comment)
We'll have to come back and fix that later (I think it's too much to fix in this PR or deno_graph upgrade)
dsherret
commented
Nov 25, 2024
js/test.ts
Outdated
| @@ -191,6 +191,7 @@ Deno.test({ | |||
| { | |||
| "specifier": "./b.js", | |||
| "code": { | |||
| "mode": "import", | |||
There was a problem hiding this comment.
Is "mode" ok, or should it be "resolutionMode"?
There was a problem hiding this comment.
IMO resolutionMode is clearer
bartlomieju
reviewed
Nov 26, 2024
js/test.ts
Outdated
| @@ -191,6 +191,7 @@ Deno.test({ | |||
| { | |||
| "specifier": "./b.js", | |||
| "code": { | |||
| "mode": "import", | |||
There was a problem hiding this comment.
IMO resolutionMode is clearer
| if !c.is_alphabetic() { | ||
| return Err(monch::ParseError::Backtrace); | ||
| } | ||
| // good enough for now |
bartlomieju
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now say if a specific import or export resolution should definitely use ESM or CJS along with supporting "resolution-mode" in TypeScript (https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-3.html#stable-support-resolution-mode-in-import-types). This information is stored in the referrer range.
It's important to know this for importing npm packages (ex. dynamic imports in cjs should load using ESM and not CJS resolution).
For denoland/deno#27059
CLI PR: denoland/deno#27071