Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky spinner test "Spinner constructor accepts interval" #6157

Open
lionel-rowe opened this issue Oct 29, 2024 · 0 comments
Open

Flaky spinner test "Spinner constructor accepts interval" #6157

lionel-rowe opened this issue Oct 29, 2024 · 0 comments
Labels
bug Something isn't working needs triage

Comments

@lionel-rowe
Copy link
Contributor

lionel-rowe commented Oct 29, 2024

Describe the bug

Test "Spinner constructor accepts interval" in cli/unstable_spinner_test.ts sometimes fails in CI due to interval running slower than expected.

https://github.com/denoland/std/actions/runs/11567686029/job/32198412079?pr=6153

Spinner constructor accepts interval => ./cli/unstable_spinner_test.ts:58:6
error: AssertionError: Expect 25 > 50
  throw new AssertionError(msg ?? `Expect ${actualString} > ${expectedString}`);
        ^
    at assertGreater (file:///D:/a/std/std/assert/greater.ts:29:9)
    at file:///D:/a/std/std/cli/unstable_spinner_test.ts:73:3

Steps to Reproduce

See above test run output

Expected behavior

No test failures

Environment

OS: Ubuntu 20.04, WSL on Windows 11
deno version: 2.0.3
std version: cli@1.0.6

@lionel-rowe lionel-rowe added bug Something isn't working needs triage labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

1 participant