Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(encoding): Promise<void> return types are unnecessary boilerplate. #818

Merged
merged 3 commits into from
Mar 26, 2021
Merged

ref(encoding): Promise<void> return types are unnecessary boilerplate. #818

merged 3 commits into from
Mar 26, 2021

Conversation

getspooky
Copy link
Contributor

We should strive for concise code. void and Promoise<void> return types are unnecessary boilerplate.
Discussion denoland/deno#8832

@getspooky getspooky changed the title ref(encoding): Promoise<void> return types are unnecessary boilerplate. ref(encoding): Promise<void> return types are unnecessary boilerplate. Mar 25, 2021
@getspooky getspooky changed the title ref(encoding): Promoise<void> return types are unnecessary boilerplate. ref(encoding): Promise<void> return types are unnecessary boilerplate. Mar 25, 2021
wperron
wperron requested changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@wperron wperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a small comment on the formatting change.

encoding/csv_test.ts Show resolved Hide resolved
@getspooky getspooky requested a review from wperron March 25, 2021 20:01
wperron
wperron approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@wperron wperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@wperron wperron merged commit d32c66e into denoland:main Mar 26, 2021
@wperron wperron mentioned this pull request Mar 26, 2021
Merged
@kt3k kt3k mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wperron wperron wperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@getspooky @wperron