From 0203beb1711de02ea088211b13cae31dcae25645 Mon Sep 17 00:00:00 2001
From: Rockwell Windsor Rice
 <129893414+rockwellwindsor-va@users.noreply.github.com>
Date: Mon, 5 Jun 2023 08:02:44 -0500
Subject: [PATCH] API-27053 526v2 currentVAEmployee not required and defaults
 to false (#12856)

* Updates 526 schema and related json files
* Updates swagger
 On branch API-27053-526-v2-currentVAEmployee-not-required
 Changes to be committed:
	modified:   modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
	modified:   modules/claims_api/config/schemas/v2/526.json
	modified:   modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json
	modified:   spec/support/schemas/claims_api/v2/forms/disability/submission.json
---
 .../claims_api/app/swagger/claims_api/v2/dev/swagger.json  | 7 +++----
 modules/claims_api/config/schemas/v2/526.json              | 4 ++--
 .../v2/request_bodies/disability_compensation/request.json | 4 ++--
 .../schemas/claims_api/v2/forms/disability/submission.json | 2 +-
 4 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json b/modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
index 706e4c1ea8b..af6bb21000e 100644
--- a/modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
+++ b/modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
@@ -1468,7 +1468,7 @@
                           "currentlyVaEmployee": {
                             "type": "boolean",
                             "description": "Flag if Veteran is VA Employee.",
-                            "example": false
+                            "default": false
                           },
                           "serviceNumber": {
                             "type": "string",
@@ -2641,14 +2641,13 @@
                             "type": "object",
                             "additionalProperties": false,
                             "required": [
-                              "mailingAddress",
-                              "currentlyVaEmployee"
+                              "mailingAddress"
                             ],
                             "properties": {
                               "currentlyVaEmployee": {
                                 "type": "boolean",
                                 "description": "Set to true if Veteran is a VA employee.",
-                                "example": false
+                                "default": false
                               },
                               "serviceNumber": {
                                 "type": "string",
diff --git a/modules/claims_api/config/schemas/v2/526.json b/modules/claims_api/config/schemas/v2/526.json
index 316f62bccd0..ffdfd99dba3 100644
--- a/modules/claims_api/config/schemas/v2/526.json
+++ b/modules/claims_api/config/schemas/v2/526.json
@@ -34,12 +34,12 @@
       "veteranIdentification": {
           "type": "object",
           "additionalProperties": false,
-          "required": ["mailingAddress", "currentlyVaEmployee"],
+          "required": ["mailingAddress"],
           "properties": {
             "currentlyVaEmployee": {
               "type": "boolean",
               "description": "Set to true if Veteran is a VA employee.",
-              "example": false
+              "default": false
             },
             "serviceNumber": {
               "type": "string",
diff --git a/modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json b/modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json
index 77e9f0d2656..1dc9b6b6b94 100644
--- a/modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json
+++ b/modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json
@@ -43,12 +43,12 @@
             "veteranIdentification": {
                 "type": "object",
                 "additionalProperties": false,
-                "required": ["mailingAddress", "currentlyVaEmployee"],
+                "required": ["mailingAddress"],
                 "properties": {
                   "currentlyVaEmployee": {
                     "type": "boolean",
                     "description": "Set to true if Veteran is a VA employee.",
-                    "example": false
+                    "default": false
                   },
                   "serviceNumber": {
                     "type": "string",
diff --git a/spec/support/schemas/claims_api/v2/forms/disability/submission.json b/spec/support/schemas/claims_api/v2/forms/disability/submission.json
index 9c4b864f2ae..33673e1af79 100644
--- a/spec/support/schemas/claims_api/v2/forms/disability/submission.json
+++ b/spec/support/schemas/claims_api/v2/forms/disability/submission.json
@@ -31,7 +31,7 @@
           "currentlyVaEmployee": {
             "type": "boolean",
             "description": "Flag if Veteran is VA Employee.",
-            "example": false
+            "default": false
           },
           "serviceNumber": {
             "type": "string",