Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with aliased npm packages #1693

Closed
swissspidy opened this issue Feb 13, 2020 · 4 comments
Closed

Issues with aliased npm packages #1693

swissspidy opened this issue Feb 13, 2020 · 4 comments
Labels
F: language-support Issues specific to a particular language or ecosystem; may be paired with an L: label. L: javascript:npm npm packages via npm Stale T: bug 🐞 Something isn't working

Comments

@swissspidy
Copy link

We're currently facing issues where Dependabot is updating an unrelated dependency in the package-lock.json file and breaking its version number in the process. Thus, CI files because npm install / npm ci doesn't work anymore as it can't find that version.

Example commit from Dependabot: https://github.com/google/web-stories-wp/pull/318/files#diff-32607347f8126e6534ebc7ebaec4853dL19202-R19204

Current master branch with correct lock file: https://github.com/google/web-stories-wp/tree/0b8acb85ddbc3d5c90dba71cc9aac5ce1e34ae95

@feelepxyz
Copy link
Contributor

@swissspidy 👋 this is a known issue and I've been sitting on this work in progress fix for quite a while: #1115

Would love to fix it but going to be a little while before we get to it. We're focused on integrating Dependabot Preview functionality natively within GitHub so we've had to pause on package manager improvements while we do this.

We're always open to contributions to dependabot-core: https://github.com/dependabot/dependabot-core

@swissspidy
Copy link
Author

Heya, @feelepxyz thanks for shedding some light on this! That's good to know.

Do you perhaps have a recommended workaround? Just avoiding aliases wherever possible?

@stale stale bot added the stale label Apr 14, 2020
@feelepxyz feelepxyz added T: bug 🐞 Something isn't working and removed stale labels Apr 14, 2020
@feelepxyz
Copy link
Contributor

Do you perhaps have a recommended workaround? Just avoiding aliases wherever possible?

Yep basically avoid where possible :(

@jurre jurre added L: javascript:npm npm packages via npm F: language-support Issues specific to a particular language or ecosystem; may be paired with an L: label. labels Feb 25, 2021
@dependabot dependabot deleted a comment from stale bot Sep 15, 2022
Copy link
Contributor

👋 This issue has been marked as stale because it has been open for 2 years with no activity. You can comment on the issue to hold stalebot off for a while, or do nothing. If you do nothing, this issue will be closed eventually by the stalebot. Please see CONTRIBUTING.md for more policy details.

@github-actions github-actions bot added the Stale label Sep 15, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: language-support Issues specific to a particular language or ecosystem; may be paired with an L: label. L: javascript:npm npm packages via npm Stale T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants