Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: dependabot incorrectly changed from one docker tag to another #3173

Closed
scyto opened this issue Feb 21, 2021 · 3 comments
Closed

bug: dependabot incorrectly changed from one docker tag to another #3173

scyto opened this issue Feb 21, 2021 · 3 comments
Labels
T: bug 🐞 Something isn't working

Comments

@scyto
Copy link

scyto commented Feb 21, 2021 •
edited
Loading

Dependabot should not have changed FROM node:erbium-buster AS local-copy-src to FROM node:15.9.0-alpine AS local-copy-src in the file docker/Dockerfile.contrib in this commit.

zwave-js/zwave-js-ui@1bb2751#diff-4ddc2e10398d5c169795b7937f893ec72d2619b395259c592156a5dd0b476c9f

We are unclear why it did this.

Note: the change to the other file in this commit was ok.
@scyto scyto added the T: bug 🐞 Something isn't working label Feb 21, 2021
@scyto scyto changed the title bug: dependabot incorrectly changed from one docker tag ro another bug: dependabot incorrectly changed from one docker tag to another Feb 21, 2021
scyto referenced this issue in zwave-js/zwave-js-ui Feb 21, 2021
@dependabot
chore(deps): bump node from 15.8.0-alpine to 15.9.0-alpine in /docker (…
1bb2751 
…#630)

Bumps node from 15.8.0-alpine to 15.9.0-alpine.

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Sarke
Copy link

Sarke commented Mar 4, 2021

Same for me. It looks like it just grabs the first tag and applies it to all the Dockerfiles.

Sarke/docker-php-fiber@66a5b4d

- FROM php:8.0.1-apache
+ FROM php:8.0.2-apache

- FROM php:8.0.1-cli
+ FROM php:8.0.2-apache

- FROM php:8.0.1-zts
+ FROM php:8.0.2-apache

This was referenced Mar 9, 2021
Closed
Merged
@feelepxyz
Copy link
Contributor

@mctofu did your PR fix this issue? #3277

@mctofu
Copy link
Contributor

mctofu commented Mar 24, 2021

Yup, the fix has been released and I tested that it covers both of these reports. We now preserve the distinction between tags like php:8.0.1-apache and php:8.0.1-cli as long as they are in separate files. The zwave-js/zwavejs2mqtt example did include node:erbium-buster and node:erbium-buster-slim in the same file but since they don't reference a version number they won't receive updates.

@mctofu mctofu mentioned this issue May 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: bug 🐞 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] docker: don't ignore version tag when consolidating dependencies dependabot/dependabot-core
4 participants
@feelepxyz @mctofu @Sarke @scyto