Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Cake-Build Projects #733

Open
gep13 opened this issue Oct 31, 2018 · 7 comments
Open

Support for Cake-Build Projects #733

gep13 opened this issue Oct 31, 2018 · 7 comments
Labels
T: new-ecosystem Requests for new ecosystems/languages

Comments

@gep13
Copy link

gep13 commented Oct 31, 2018

Edit from the Dependabot team: This is the main tracking issue for adding support for Cake.

PR:
#958

Related Issues:
#733


It would be great if dependabot could support updating dependencies which are defined by people using Cake-Build (https://cakebuild.net/).

Cake is a build automation framework, that allows people to take a dependency on NuGet packages that are either an addin, tool or module. You can see examples of the types of dependency definitions here:

https://github.com/cake-contrib/Cake.Recipe/blob/develop/Cake.Recipe/Content/addins.cake#L5-L23
https://github.com/cake-contrib/Cake.Recipe/blob/develop/Cake.Recipe/Content/tools.cake#L5-L20
https://github.com/chocolatey/ChocolateyGUI/blob/develop/setup.cake#L1
https://github.com/chocolatey/ChocolateyGUI/blob/develop/setup.cake#L2

Notice, that there are different ways for these dependencies to be expressed, based on how the project is created.

Cake itself is also a dependency, which is normally defined in the tools/packages.config files, as shown here:

https://github.com/cake-contrib/Cake.Recipe/blob/develop/tools/packages.config

This is just a normal NuGet packages.config file, so this might already be supported in dependabot today.

We already have an attempt at doing something similar to this on a much smaller scale. For example this PR:

cake-contrib/Cake.Recipe#263

Was created by our automated process.

Documentation on the pre-processor directives that can define these dependencies can be found here:

https://cakebuild.net/docs/fundamentals/preprocessor-directives

./cc @greysteil

@gitfool
Copy link

gitfool commented Jan 22, 2019

@greysteil I’d also love to have this. What’s involved to make it so? Would it be best done by extending the existing NuGet implementation, or would it be a separate implementation? 🤔

@gep13
Copy link
Author

gep13 commented Jan 22, 2019

@gitfool I had an email conversation with @greysteil about this at the time that I created this issue. Here is what was said...

@greysteil said...
Sounds like we could add this to Dependabot as a new language. The place we’d need to add it is here and there’s an example of a PR that adds a new language here. I’m happy to help out if you’re keen (or if you have anyone who can write Ruby they could probably do it without much help), but am a little swamped for the next couple of weeks. Do you want to open an issue on dependabot core either way, and we can take it from there?

I don't know enough Ruby to help on this, but happy to review/test anything that you might come up with.

@greysteil
Copy link
Contributor

Yep, what @gep13 said! I'm super busy at the moment (a couple of big things coming on Dependabot) but always happy to help out. If enough people want this I'll take it on myself when things calm down, too.

@gitfool
Copy link

gitfool commented Jan 24, 2019

@greysteil FWIW, I'm having a look around and some of the repo file names have colons (:) in them which are invalid file name characters on Windows:

$ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        deleted:    composer/spec/fixtures/packagist_responses/dependabot:dummy-pkg-a.json
        deleted:    composer/spec/fixtures/packagist_responses/doctrine:dbal.json
        deleted:    composer/spec/fixtures/packagist_responses/illuminate:console.json
        deleted:    composer/spec/fixtures/packagist_responses/illuminate:support.json
        deleted:    composer/spec/fixtures/packagist_responses/longman:telegram-bot.json
        deleted:    composer/spec/fixtures/packagist_responses/monolog:monolog.json
        deleted:    composer/spec/fixtures/packagist_responses/neos:flow.json
        deleted:    composer/spec/fixtures/packagist_responses/path_dep:path_dep.json
        deleted:    composer/spec/fixtures/packagist_responses/pear-pear.horde.org:horde_date.json
        deleted:    composer/spec/fixtures/packagist_responses/phpdocumentor:reflection-docblock.json
        deleted:    composer/spec/fixtures/packagist_responses/symfony:polyfill-mbstring.json
        deleted:    composer/spec/fixtures/packagist_responses/wpackagist-plugin:acf-to-rest-api.json

I'd prefer to use Windows Subsystem for Linux (WSL) for the Ruby environment while editing in Windows with Visual Studio Code, but then these file names will still cause me grief.

@greysteil
Copy link
Contributor

I had no idea! Fixed in 4db144e.

@gitfool

This comment was marked as outdated.

@stale stale bot removed the wontfix label Oct 23, 2019
@feelepxyz feelepxyz added the T: feature-request Requests for new features label Oct 23, 2019
@Jacob-Morgan Jacob-Morgan mentioned this issue May 8, 2020
6 tasks
@infin8x infin8x added F: language-support Issues specific to a particular language or ecosystem; may be paired with an L: label. T: new-ecosystem Requests for new ecosystems/languages and removed L: dotnet:cake T: feature-request Requests for new features F: language-support Issues specific to a particular language or ecosystem; may be paired with an L: label. labels Jul 2, 2020
@nils-a
Copy link

nils-a commented Oct 6, 2020

@Jacob-Morgan @gitfool I saw that others created github-actions (ex. https://github.com/patrickjahns/dependabot-terraform-action) to "extend" dependabot in that way while waiting for the "real" implementation in dependabot.

Would that be a "temporary fix" while we're all waiting on this issue?

@dependabot dependabot deleted a comment from stale bot Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: new-ecosystem Requests for new ecosystems/languages
Projects
None yet
Development

No branches or pull requests

7 participants