[WIP] JS: Parse aliased package details #1115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@feelepxyz FYI, this is a start to properly supporting aliased packages. I abandoned it because it will need at least another couple of hours work, and I need to jump on other stuff. |
|
Nice work starting this! Happy to take over and keep working on this
tomorrow.
…On Tue, 23 Apr 2019 at 11:56, Grey Baker ***@***.***> wrote:
@feelepxyz <https://github.com/feelepxyz> FYI, this is a start to
properly supporting aliased packages. I abandoned it because it will need
at least another couple of hours work, and I need to jump on other stuff.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1115 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAE5RIVEWOEWZZP7CT3XC3PR3TPNANCNFSM4HHW2IFQ>
.
|
feelepxyz
added a commit
that referenced
this pull request
Aug 20, 2019
Fixes an update error for `github/stardust-frontend` caused by this alias: https://github.com/github/stardust-frontend/blob/master/web/package.json#L45 Ignore any deps with aliases in the name until we've added full support which was started here: #1115
feelepxyz
added
T: feature-request
|
👋 This pull request has been marked as stale because it has been open for 2 years with no activity. You can comment on the PR to hold stalebot off for a while, or do nothing. If you do nothing, this pull request will be closed eventually by the stalebot. Please see CONTRIBUTING.md for more policy details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a start to handling aliased JS dependencies properly. It still needs a bunch of work:
aliased_package_namein the update check and file updater, and ensure those workaliased_package_nameinto a metadata hash (like we do for property names in our Java package managers, for example)