Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.138.4 #3354

Merged
merged 1 commit into from
Mar 25, 2021
Merged

v0.138.4 #3354

merged 1 commit into from
Mar 25, 2021

Conversation

@thepwagner thepwagner requested a review from a team as a code owner March 25, 2021 15:37
@thepwagner thepwagner self-assigned this Mar 25, 2021
Copy link
Contributor

@brrygrdn brrygrdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feelepxyz
Copy link
Contributor

Looks like #3351 snuck in also.

Would be nice to have something in place to prevent this from happening or rejig our workflow. This has happened a few times recently with release PRs waiting for CI.

@thepwagner
Copy link
Contributor Author

Would be nice to have something in place to prevent this from happening or rejig our workflow

Small change: we could just tag from the branch's tip instead of tagging the merge commit?

Bigger change: orienting around GitHub releases might be interesting - this "double-check my release notes" style of PR could perhaps be a "draft release".

For this build in particular I'm going to stick with tagging the merge commit as I don't fear #3351 (it actually sounds rather useful!). Thanks for flagging.

@thepwagner thepwagner merged commit a2b1d75 into main Mar 25, 2021
@thepwagner thepwagner deleted the v0.138.4-release-notes branch March 25, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants