use the ssh-config-file with the actual ssh cmd

[mwr]

Q	A
Issue Type	Question
Deployer Version	master
Local Machine OS	---
Remote Machine OS	---

Description

One can provide the server config with a configFile like this:
$production->configFile('path/to/file');

In the first place I assumed this file would then be used with the actual ssh command.
But as it turns out is just used to gather some information out of it.

So is there a reason why this is not done?

See here:
https://github.com/deployphp/deployer/blob/master/src/Server/Remote/NativeSsh.php#L51

In my local dev environment I added -i path/to/file in the above mentioned class and it worked out well.

[antonmedv]

Config file is used only for getting config about servers.

[mwr]

Thanks @Elfet for your fast response.
OK, that's what I figured. But is there something preventing us from adding the possibility to use the ssh-config file in the command?
If not I would be happy to create a pull request to add that feature.

[antonmedv]

You want to not to use config file?

[antonmedv]

There actually a research #980 from me, i'm going to improve whole ssh system at deployer.

[mwr]

I want to use the native ssh implementaion and use the config file as a parameter.
Right now the config file is only used to fetch information.
I want to use it for the actual connection.
Thus adding the possibility to use all the features we have available in the native ssh command like ProxyCommand etc.

Like this:

    /**
     * {@inheritdoc}
     */
    public function run($command)
    {
        $serverConfig = $this->getConfiguration();
        $sshOptions = [
            '-A',
            '-q',
            '-i __PATH_TO_SSH_CONFIG_FILE__',
            '-o UserKnownHostsFile=/dev/null',
            '-o StrictHostKeyChecking=no'
        ];

And I like the approach of using native ssh :)

[antonmedv]

@mwr i will implement this. All $sshOptions should be configurable.

[mwr]

@Elfet looking forward to that. Will be a great addition.

[antonmedv]

#980

[pluseg]

@Elfet please close the ticket as it's done.