From 509b9f0d8608a40a127ee6e59486ae4c1ec6e734 Mon Sep 17 00:00:00 2001 From: jpveooys <66470099+jpveooys@users.noreply.github.com> Date: Fri, 25 Mar 2022 15:28:25 +0000 Subject: [PATCH 1/5] fix(playwright): Await page close In the interest of correctness and to match puppeteer. --- packages/playwright/src/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/playwright/src/index.ts b/packages/playwright/src/index.ts index dd952a37..85c502f7 100644 --- a/packages/playwright/src/index.ts +++ b/packages/playwright/src/index.ts @@ -290,8 +290,8 @@ export default class AxeBuilder { partialResults, options }) - .finally(() => { - blankPage.close(); + .finally(async () => { + await blankPage.close(); }); } } From 554470a7846c7e35d161ea38a3b323b28d07af90 Mon Sep 17 00:00:00 2001 From: jpveooys <66470099+jpveooys@users.noreply.github.com> Date: Fri, 25 Mar 2022 15:23:00 +0000 Subject: [PATCH 2/5] fix(puppeteer): Await page close This resolves an intermittent 'ProtocolError: Protocol error (Target.closeTarget): Target closed.' error at the end of a test suite run depending on the environment. --- packages/puppeteer/src/axePuppeteer.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/puppeteer/src/axePuppeteer.ts b/packages/puppeteer/src/axePuppeteer.ts index 27ad182c..6d795f10 100644 --- a/packages/puppeteer/src/axePuppeteer.ts +++ b/packages/puppeteer/src/axePuppeteer.ts @@ -280,8 +280,8 @@ export class AxePuppeteer { partialResults as JSONArray, axeOptions as JSONObject ) - .finally(() => { - blankPage.close(); + .finally(async () => { + await blankPage.close(); }); } From cc8ed5310ab7b3a807f02e8328423754cfed61f0 Mon Sep 17 00:00:00 2001 From: Gabe <41127686+Zidious@users.noreply.github.com> Date: Mon, 4 Apr 2022 20:53:14 +0100 Subject: [PATCH 3/5] add verbose to BRM --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 7abb73a1..6eaacade 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -134,7 +134,7 @@ jobs: - restore_dependency_cache # Re-build packages, ensuring packages/webdriverjs/dist exists. - run: npx lerna run prepare - - run: npx browser-driver-manager@1.0.4 install chrome chromedriver + - run: npx browser-driver-manager@1.0.4 install chrome chromedriver --verbose - run: npm run coverage --prefix=packages/cli puppeteer: From 5517ed2af6e8e49c9644c8f1614d5c89eee5783c Mon Sep 17 00:00:00 2001 From: Gabe <41127686+Zidious@users.noreply.github.com> Date: Mon, 4 Apr 2022 21:03:07 +0100 Subject: [PATCH 4/5] update config.yml CI --- .circleci/config.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 6eaacade..1b7847b6 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -134,7 +134,7 @@ jobs: - restore_dependency_cache # Re-build packages, ensuring packages/webdriverjs/dist exists. - run: npx lerna run prepare - - run: npx browser-driver-manager@1.0.4 install chrome chromedriver --verbose + - run: cd packages/cli && npx browser-driver-manager@1.0.4 install chrome chromedriver --verbose - run: npm run coverage --prefix=packages/cli puppeteer: @@ -143,7 +143,7 @@ jobs: - checkout - restore_dependency_cache - run: npm run build --prefix=packages/puppeteer - - run: npx browser-driver-manager@1.0.4 install chrome chromedriver + - run: cd packages/puppeteer && npx browser-driver-manager@1.0.4 install chrome chromedriver --verbose - run: npm run coverage --prefix=packages/puppeteer webdriverjs: @@ -151,7 +151,7 @@ jobs: steps: - checkout - restore_dependency_cache - - run: npx browser-driver-manager@1.0.4 install chrome chromedriver + - run: cd packages/webdriverjs && npx browser-driver-manager@1.0.4 install chrome chromedriver --verbose - run: npm --prefix=packages/webdriverjs run build - run: npm run coverage --prefix=packages/webdriverjs @@ -170,7 +170,7 @@ jobs: steps: - checkout - restore_dependency_cache - - run: npx browser-driver-manager@1.0.4 install chrome chromedriver + - run: cd packages/webdriverio && npx browser-driver-manager@1.0.4 install chrome chromedriver --verbose - run: npm run coverage --prefix=packages/webdriverio reporter-earl: From 45e179171dc0f055df4358a3ea5b7e0da96a5dc6 Mon Sep 17 00:00:00 2001 From: Gabe <41127686+Zidious@users.noreply.github.com> Date: Mon, 4 Apr 2022 21:10:10 +0100 Subject: [PATCH 5/5] add lerna link after chromedriver installation --- .circleci/config.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 1b7847b6..ff77e8d2 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -135,6 +135,8 @@ jobs: # Re-build packages, ensuring packages/webdriverjs/dist exists. - run: npx lerna run prepare - run: cd packages/cli && npx browser-driver-manager@1.0.4 install chrome chromedriver --verbose + # lerna link after installing the latest version of chromedriver, as we depend on webdriverJS + - run: cd packages/cli && npx lerna link - run: npm run coverage --prefix=packages/cli puppeteer: