fix(color-contrast-matches): do not pass empty string to getElementBy…

…Id (#2739)
dequelabs · Jan 8, 2021 · 0b0fec2 · 0b0fec2
1 parent 159e25b
commit 0b0fec2
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/lib/rules/color-contrast-matches.js b/lib/rules/color-contrast-matches.js
@@ -69,14 +69,17 @@ function colorContrastMatches(node, virtualNode) {
       : virtualNode;
 
     // explicit label of disabled control
-    const doc = getRootNode(labelNode);
-    const explicitControl = doc.getElementById(labelNode.htmlFor || '');
-    const explicitControlVirtual =
-      explicitControl && getNodeFromTree(explicitControl);
+    if (labelNode.htmlFor) {
+      const doc = getRootNode(labelNode);
+      const explicitControl = doc.getElementById(labelNode.htmlFor);
+      const explicitControlVirtual =
+        explicitControl && getNodeFromTree(explicitControl);
 
-    if (explicitControlVirtual && isDisabled(explicitControlVirtual)) {
-      return false;
+      if (explicitControlVirtual && isDisabled(explicitControlVirtual)) {
+        return false;
+      }
     }
+
     // implicit label of disabled control
     const query =
       'input:not([type="hidden"]):not([type="image"])' +