test: fix aria practices tests not running (#3922)

* tests: fix aria practices tests not running

* add --zero-fail option

package.json

@@ -83,14 +83,14 @@
     "test:unit:integration": "npm run test:unit -- testDirs=integration",
     "test:unit:virtual-rules": "npm run test:unit -- testDirs=virtual-rules",
     "integration": "node test/integration/full/test-webdriver.js",
-    "integration:apg": "mocha test/aria-practices/*.spec.js",
+    "integration:apg": "mocha --fail-zero test/aria-practices/*.spec.js",
     "integration:chrome": "npm run integration -- browser=Chrome",
     "integration:firefox": "npm run integration -- browser=Firefox",
     "test:integration": "npm run test:integration:chrome",
     "test:integration:chrome": "start-server-and-test 9876 integration:chrome",
     "test:integration:firefox": "start-server-and-test 9876 integration:firefox",
     "test:examples": "node ./doc/examples/test-examples",
-    "test:act": "mocha test/act-rules/*.spec.js",
+    "test:act": "mocha --fail-zero test/act-rules/*.spec.js",
     "test:apg": "start-server-and-test 9876 integration:apg",
     "test:locales": "mocha test/test-locales.js",
     "test:virtual-rules": "mocha test/test-virtual-rules.js",

test/act-rules/act-runner.js

@@ -2,15 +2,10 @@ const path = require('path');
 const fs = require('fs');
 const http = require('http');
 const handler = require('serve-handler');
-const chromedriver = require('chromedriver');
 const AxeBuilder = require('@axe-core/webdriverjs');
-const {
-  getWebdriver,
-  connectToChromeDriver
-} = require('../aria-practices/run-server');
+const { getWebdriver } = require('../get-webdriver');
 const { assert } = require('chai');
 
-const driverPort = 9515;
 const serverPort = 9898;
 const axePath = require.resolve('../../axe.js');
 const axeSource = fs.readFileSync(axePath, 'utf8');
@@ -34,9 +29,6 @@ module.exports = ({ id, title, axeRules, skipTests = [] }) => {
     this.retries(3);
 
     before(async () => {
-      chromedriver.start([`--port=${driverPort}`]);
-      await new Promise(r => setTimeout(r, 500));
-      await connectToChromeDriver(driverPort);
       driver = getWebdriver();
     });
 
@@ -59,7 +51,6 @@ module.exports = ({ id, title, axeRules, skipTests = [] }) => {
 
     after(async () => {
       await driver.close();
-      chromedriver.stop();
       await new Promise(r => server.close(r));
     });
 

test/aria-practices/apg.spec.js

@@ -1,8 +1,7 @@
 const path = require('path');
 const fs = require('fs');
-const chromedriver = require('chromedriver');
 const AxeBuilder = require('@axe-core/webdriverjs');
-const { getWebdriver, connectToChromeDriver } = require('./run-server');
+const { getWebdriver } = require('../get-webdriver');
 const { assert } = require('chai');
 const globby = require('globby');
 
@@ -13,7 +12,6 @@ describe('aria-practices', function () {
   const testFiles = filePaths.map(
     fileName => fileName.split('/aria-practices/examples/')[1]
   );
-  const port = 9515;
   const addr = `http://localhost:9876/node_modules/aria-practices/`;
   let driver, axeSource;
   this.timeout(50000);
@@ -22,15 +20,11 @@ describe('aria-practices', function () {
   before(async () => {
     const axePath = require.resolve('../../axe.js');
     axeSource = fs.readFileSync(axePath, 'utf8');
-    chromedriver.start([`--port=${port}`]);
-    await new Promise(r => setTimeout(r, 500));
-    await connectToChromeDriver(port);
     driver = getWebdriver();
   });
 
   after(async () => {
     await driver.close();
-    chromedriver.stop();
   });
 
   const disabledRules = {

test/get-webdriver.js

@@ -0,0 +1,16 @@
+const { Builder } = require('selenium-webdriver');
+const chrome = require('selenium-webdriver/chrome');
+const chromedriverPath = require('chromedriver').path;
+
+const getWebdriver = () => {
+  const service = new chrome.ServiceBuilder(chromedriverPath);
+
+  const webdriver = new Builder()
+    .setChromeOptions(new chrome.Options().headless())
+    .forBrowser('chrome')
+    .setChromeService(service)
+    .build();
+  return webdriver;
+};
+
+module.exports.getWebdriver = getWebdriver;