diff --git a/lib/checks/color/color-contrast-evaluate.js b/lib/checks/color/color-contrast-evaluate.js index 638f81bec1..4bfb19d794 100644 --- a/lib/checks/color/color-contrast-evaluate.js +++ b/lib/checks/color/color-contrast-evaluate.js @@ -99,20 +99,20 @@ function colorContrastEvaluate(node, options, virtualNode) { // if element or a parent has pseudo content then we need to mark // as needs review - let parentNode = node.parentElement; - while (parentNode) { + let nodeToCheck = node; + while (nodeToCheck) { if ( - hasPsuedoElement(parentNode, ':before') || - hasPsuedoElement(parentNode, ':after') + hasPsuedoElement(nodeToCheck, ':before') || + hasPsuedoElement(nodeToCheck, ':after') ) { this.data({ messageKey: 'pseudoContent' }); - this.relatedNodes(parentNode); + this.relatedNodes(nodeToCheck); return undefined; } - parentNode = parentNode.parentElement; + nodeToCheck = nodeToCheck.parentElement; } // ratio is outside range diff --git a/test/integration/full/incomplete/color-contrast.html b/test/integration/full/incomplete/color-contrast.html index 1afde31d13..b7f333048c 100644 --- a/test/integration/full/incomplete/color-contrast.html +++ b/test/integration/full/incomplete/color-contrast.html @@ -43,7 +43,25 @@
Text over gradient
+ + + +