fix false positive related to role="combobox"

[dylanb]

Has been reported in dequelabs/axe-firefox-devtools#33

[dylanb]

The solution should be the following:

If the element on which the role has been placed is a native input element, then make the required children optional

[WilcoFiers]

I raised this issue on html-aria and Steve Faulkner got back on it. We have a different issue. Axe has two 'types' of 'owned' propertyes, 'all' and 'one'. All means every one of the roles is required, one means just one of them. ARIA doesn't actually ever require all children to be present. combobox is the only role in Axe which is set to require multiple children. Other uses of 'all' only has one role.

The fix is to change this to 'one'. Though I think it's probably better to also remove this difference all together as it adds unnecessary complexity.

[dylanb]

If there is a combobox implementation that does not use a standard input element and also does not have a textbox child, then this will have severe compatibility issues when a screen reader is turned on.

For that reason, I think we should still raise the issue if there is no native element (note: this would be a temporary solution until the issue gets resolved in ARIA).

[johncaseysmith]

Hey @dylanb, any updates on this? Does the previously mentioned solution still apply?

[adamliptrot-oc]

Hi, what's the current situation with this? I'm running into this issue with automated testing.

[isner]

Proposed solution: #481

[marcysutton]

Fixed with #481.