Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rule label to correct SC #2014

Closed
jeeyyy opened this issue Feb 4, 2020 · 4 comments
Closed

Update rule label to correct SC #2014

jeeyyy opened this issue Feb 4, 2020 · 4 comments
Assignees
Labels
ACT Rules docs Documentation changes rule metadata Issues in the rule metadata code (lib/rules)

Comments

@jeeyyy
Copy link
Contributor

jeeyyy commented Feb 4, 2020

Expectation:
Rule label should map to SC 4.1.2 instead of 3.3.2

Actual:
See above

Motivation:
Needed for implementation of rule - https://act-rules.github.io/rules/e086e5


axe-core version: X.Y.Z
axe-webdriver, extension or other integration version: X.Y.Z

Browser and Assistive Technology versions

For Tooling issues:
- Node version: XX  
- Platform:  
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Feb 4, 2020

@JKODU to verify if this fix completes the implementation for above ACT Rule

@jeeyyy jeeyyy self-assigned this Feb 4, 2020
@straker straker added docs Documentation changes rule metadata Issues in the rule metadata code (lib/rules) labels Feb 7, 2020
@jeeyyy jeeyyy closed this as completed Feb 12, 2020
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Feb 28, 2020

@jeankaplansky reopening issue, to check if this needs to be documented

@jeeyyy jeeyyy reopened this Feb 28, 2020
@padmavemulapati
Copy link

Verified with latest axe-coconut (v4.3.0.06000 ), seeing the change from wcag332 to wcag412. Attached the screenshots.
(without update rule label - tag is wcag332)
image
(after updating rule label - tag is wcag412)
image

@jeeyyy jeeyyy changed the title Update rule label to correct SC [QA] Update rule label to correct SC Mar 2, 2020
@jeeyyy jeeyyy changed the title [QA] Update rule label to correct SC Update rule label to correct SC Mar 9, 2020
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Mar 9, 2020

Worked with DQU to update tags respectively in DQU content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACT Rules docs Documentation changes rule metadata Issues in the rule metadata code (lib/rules)
Projects
None yet
Development

No branches or pull requests

3 participants