Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make accessible name rules run exclusively on VirtualNode #2183

Closed
36 tasks done
WilcoFiers opened this issue Apr 28, 2020 · 0 comments
Closed
36 tasks done

Make accessible name rules run exclusively on VirtualNode #2183

WilcoFiers opened this issue Apr 28, 2020 · 0 comments
Assignees
Labels
linting Axe-linter issues
Milestone

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Apr 28, 2020

This is part of our larger project to create a better abstraction layer in axe-core. For the 4.0, we want to have the following rules run exclusively on the virtualNode object (e.g. without anything in matches / evaluate / after, or any of the commons it uses touch the .actualNode property, or use the node parameter.

Rules

The following rules will be enabled to run exclusively on virtualNode:

  • image-alt
  • area-alt
  • frame-title
  • input-image-alt
  • link-name
  • object-alt
  • button-name
  • input-button-name
  • role-img-alt
  • svg-img-alt
  • aria-toggle-field-name
  • aria-input-field-name
  • label

Checks

To enable this, the following checks will have to be converted:

  • alt-space-value
  • aria-label
  • aria-labelledby
  • focusable-no-name (maybe integrate this into role-none / role-presentation?)
  • has-alt
  • non-empty-alt
  • non-empty-title
  • has-visible-text
  • role-none
  • role-presentation
  • button-has-visible-text
  • non-empty-if-present
  • non-empty-value
  • svg-non-empty-title
  • no-implicit-explicit-label
  • implicit-label
  • explicit-label
  • help-same-as-label
  • hidden-explicit-label

Match functions

Additionally, a few match functions will have to be converted as well:

  • html-namespace-matches.js
  • svg-namespace-matches.js
  • aria-form-field-name-matches.js
  • label-matches.js
@WilcoFiers WilcoFiers added this to the Axe-core 4.0 milestone Apr 28, 2020
@WilcoFiers WilcoFiers added the linting Axe-linter issues label May 4, 2020
@straker straker self-assigned this Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linting Axe-linter issues
Projects
None yet
Development

No branches or pull requests

3 participants