Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aria-valid-attr-value): return false when int type attribute uses invalid values #2710

Merged
merged 2 commits into from
Jan 4, 2021
Merged

fix(aria-valid-attr-value): return false when int type attribute uses invalid values #2710

merged 2 commits into from
Jan 4, 2021

Conversation

straker
Copy link
Contributor

@straker straker commented Dec 21, 2020

Adding a new minValue property to aria-attrs standards object that controls what the minimum value of an int type attribute is. For example, aria-level has a min value of 1 as you can't go below that for a heading level.

Closes issue: #1288

@straker straker requested a review from a team as a code owner December 21, 2020 23:28
@straker straker merged commit ce9917e into develop Jan 4, 2021
@straker straker deleted the int-valid-attr-value branch January 4, 2021 15:24
@WilcoFiers WilcoFiers mentioned this pull request Apr 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers