Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color-contrast-matches): do not pass empty string to getElementById #2739

Merged
merged 1 commit into from
Jan 8, 2021
Merged

fix(color-contrast-matches): do not pass empty string to getElementById #2739

merged 1 commit into from
Jan 8, 2021

Conversation

straker
Copy link
Contributor

@straker straker commented Jan 7, 2021

In Firefox, a warning is logged when passing an empty string to document.getElementById. This changes the color-contrast-matches code so we don't do that anymore for implicit labels.

image

Closes issue: #2729

@straker straker requested a review from a team as a code owner January 7, 2021 21:19
WilcoFiers
WilcoFiers requested changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test

@straker straker merged commit 0b0fec2 into develop Jan 8, 2021
@straker straker deleted the label-firefox branch January 8, 2021 16:48
@WilcoFiers WilcoFiers mentioned this pull request Apr 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers