Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-prohibited-attr should always report incomplete if there is text in the subtree #3346

Closed
WilcoFiers opened this issue Jan 12, 2022 · 1 comment
Labels
fix Bug fixes pr A pr has been created for the issue
Milestone

Comments

@WilcoFiers
Copy link
Contributor

The following should have been reported as incomplete, but is failed instead:

<div role="code" aria-label="foo">Hello world</div>

It should only fail if the content is missing, like in the following:

<div role="code" aria-label="foo"></div>

This already works without the role. It goes bad because subtreeText isn't called correctly.

@WilcoFiers WilcoFiers added fix Bug fixes pr A pr has been created for the issue labels Jan 12, 2022
@WilcoFiers WilcoFiers added this to the Axe-core 4.4 milestone Jan 12, 2022
@padmavemulapati
Copy link

Validated with the latest dev branch code base, and the test snippet
<div role="code" aria-label="foo">Hello world</div> , it is showing incomplete results as shown in the screenshot:
image
It was failing earlier with the same code snippet instead incomplete
image

It fails when <div role="code" aria-label="foo"></div>

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes pr A pr has been created for the issue
Projects
None yet
Development

No branches or pull requests

2 participants