Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WCAG tags for consistency with ACT rules #3458

Closed
5 tasks done
WilcoFiers opened this issue May 17, 2022 · 3 comments
Closed
5 tasks done

Update WCAG tags for consistency with ACT rules #3458

WilcoFiers opened this issue May 17, 2022 · 3 comments
Assignees
@WilcoFiers
Labels
ACT Rules rule metadata Issues in the rule metadata code (lib/rules)
Milestone
Axe-core 4.5

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented May 17, 2022 •
edited
Loading

The following rules have tags that are inconsistent with the ACT requirements mapping. I would like to have these changes made to improve our consistency with ACT.

  • label: Remove wcag131
  • select-name: Remove wcag131
  • aria-hidden-focus remove wcag131
  • input-image-alt Add wcag412
  • area-alt: Remove wcag111

Because of how the changelog gets generated, I we can not do them all in one pull request. We should have the wcag131 changes in one pull request, and then the other two changes in separate pull requests.
@WilcoFiers WilcoFiers added ACT Rules good first issue For first-time contributors labels May 17, 2022
@WilcoFiers WilcoFiers added this to the Axe-core 4.5 milestone May 17, 2022
@WilcoFiers WilcoFiers removed the good first issue For first-time contributors label May 18, 2022
@WilcoFiers
Copy link
Contributor Author

Nobody pick this up yet please. I need to have a few conversations before we take this on.

@WilcoFiers WilcoFiers added the rule metadata Issues in the rule metadata code (lib/rules) label May 20, 2022
@WilcoFiers WilcoFiers self-assigned this May 20, 2022
@WilcoFiers
Copy link
Contributor Author

These are all agreed on. We're ready to put these in.

This was referenced May 24, 2022
Merged
Merged
Merged
Merged
@padmavemulapati
Copy link

Validated with the latest axe-core, develop branch code base,

  1. for label, removed wcag131
    image

  2. for 'select-nameremovedwcag131`
    image

  3. for aria-hidden-focus removed wcag131
    image

  4. for input-image-alt , added wcag412
    image

5.for aria-alt , removed wcag111
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WilcoFiers WilcoFiers

Labels
ACT Rules rule metadata Issues in the rule metadata code (lib/rules)
Projects
None yet
Milestone
Axe-core 4.5
Development

No branches or pull requests
2 participants
@WilcoFiers @padmavemulapati