fix: do not warn when using webpack #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps an issue should be created in the |
straker
commented
Nov 14, 2022
| @@ -1082,12 +1082,14 @@ describe('color.getBackgroundColor', function () { | |||
| it('returns the html background', function () { | |||
| fixture.innerHTML = '<div id="target"><label>elm<input></label></div>'; | |||
| document.documentElement.style.background = '#0F0'; | |||
| document.body.setAttribute('style', 'background: unset'); | |||
There was a problem hiding this comment.
Seems Mocha added default styles to body in a recent update, one of which was a white background and black foreground. So needed to unset the background color for the test.
WilcoFiers
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the steps in the ticket, this fixes the webpack output to not warn of the critical dependency. Seems something about esbuild v0.11+ causes the problem. For now this is a fix to the problem, but I'll investigate further at some later date to see if I can figure out what's going on.
Closes issue: #3771