Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target-size rule contains typos #4148

Closed
1 task done
adamraine opened this issue Sep 6, 2023 · 1 comment · Fixed by #4151
Closed
1 task done

target-size rule contains typos #4148

adamraine opened this issue Sep 6, 2023 · 1 comment · Fixed by #4151
Labels
rule metadata Issues in the rule metadata code (lib/rules)
Milestone
Axe-core 4.9.0

Comments

@adamraine
Copy link

Product

axe-core

Product Version

4.8.0

Latest Version

  • I have tested the issue with the latest version of the product

Issue Description

Expectation

Failure message ends with:
"Safe clickable space has a diameter of 10px instead of at least 24px"

10px is just an example value.

Actual

Failure message ends with:
"Safe clickable space has a diameter of {$data.closestOffset}px instead of at least 24px)"

It appears that the actual data.closestOffset value is not being filled in. There is also an unpaired ) at the end of the string that I think should be removed.

How to Reproduce

Any code that fails the target-size rule.

Additional context

#4117
@adamraine adamraine added the ungroomed Ticket needs a maintainer to prioritize and label label Sep 6, 2023
@straker
Copy link
Contributor

straker commented Sep 6, 2023

Ops, you're right. Thanks for spotting that. We'll get it fixed for the next release.

@straker straker added rule metadata Issues in the rule metadata code (lib/rules) and removed ungroomed Ticket needs a maintainer to prioritize and label labels Sep 6, 2023
@straker straker added this to the Axe-core 4.9 milestone Sep 6, 2023
@adamraine adamraine mentioned this issue Sep 6, 2023
Merged
@WilcoFiers WilcoFiers mentioned this issue Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rule metadata Issues in the rule metadata code (lib/rules)
Projects
None yet
Milestone
Axe-core 4.9.0
Development

Successfully merging a pull request may close this issue.

fix(target-size): show closest offset in message dequelabs/axe-core
3 participants
@WilcoFiers @straker @adamraine