Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated rules shouldn't run if their WCAG tag is configured #4523

Closed
WilcoFiers opened this issue Jul 2, 2024 · 0 comments · Fixed by #4526 · May be fixed by Stanislav1975/sitespeed.io#11, Stanislav1975/sitespeed.io#12 or organich/lighthouse#4
Closed

Deprecated rules shouldn't run if their WCAG tag is configured #4523

WilcoFiers opened this issue Jul 2, 2024 · 0 comments · Fixed by #4526 · May be fixed by Stanislav1975/sitespeed.io#11, Stanislav1975/sitespeed.io#12 or organich/lighthouse#4
Assignees
@WilcoFiers
Labels
core Issues in the core code (lib/core) pr A pr has been created for the issue support
Milestone
Axe-core 4.10

Comments

@WilcoFiers
Copy link
Contributor

The aria-roledescription rule was deprecated a while ago. In axe-core this was disabled and tagged as deprecated. That should have turned it off in all tools that use axe-core. It has done so in axe extension, but because of the way tags work in axe-core, it didn't turn the rule of the various axe SDKs (as well as anything built on top of them).

We'll want the following to be true:

axe.run({ runOnly: ['wcag2a'] }) // does **not** run aria-roledescription
axe.run({ runOnly: ['wcag2a', 'deprecated' }) // Runs aria-roledescription
axe.run({ rules: { rules: { "aria-roledescription": { enabled: true } } } }) // Runs aria-roledescription

This should make deprecated rules work the same as experimental rules. And since it'll work the same way, we can use the same mechanism. We should be able to do this by adding "deprecated" to the tagExclude option.
@WilcoFiers WilcoFiers added core Issues in the core code (lib/core) support labels Jul 2, 2024
@WilcoFiers WilcoFiers added this to the Axe-core 4.10 milestone Jul 2, 2024
@WilcoFiers WilcoFiers self-assigned this Jul 5, 2024
@WilcoFiers WilcoFiers mentioned this issue Jul 5, 2024
Merged
@WilcoFiers WilcoFiers added the pr A pr has been created for the issue label Jul 8, 2024
@attest-team-ci attest-team-ci mentioned this issue Jul 29, 2024
Merged
WilcoFiers added a commit that referenced this issue Jul 29, 2024
@WilcoFiers
chore(release): v4.10.0 (#4545)
c49c8ea 
##
[4.10.0](v4.9.1...v4.10.0)
(2024-07-29)

### Features

- **new-rule:** summary elements must have an accessible name
([#4511](#4511))
([0d8a99e](0d8a99e)),
closes [#4510](#4510)

### Bug Fixes

- **all-rules:** fix flakey all-rules firefox test
([#4467](#4467))
([3f13aa1](3f13aa1))
- **aria-allowed-attr:** allow aria-multiline=false for element with
contenteditable
([#4537](#4537))
([f019068](f019068))
- **aria-allowed-attr:** allow aria-required=false when normally not
allowed ([#4532](#4532))
([2e242e1](2e242e1))
- **aria-prohibited-attr:** allow aria-label/ledby on decendants of
widget ([#4541](#4541))
([07c5d91](07c5d91))
- **aria-roledescription:** keep disabled with { runOnly: 'wcag2a' }
([#4526](#4526))
([5b4cb9d](5b4cb9d)),
closes [#4523](#4523)
- **autocomplete-valid:** incomplete for invalid but safe values
([#4500](#4500))
([e31a974](e31a974)),
closes [#4492](#4492)
- **build:** limit locales to valid files when using the --all-lang
option ([#4486](#4486))
([d3db593](d3db593)),
closes [#4485](#4485)
- colorio.js patch mocking CSS
([#4456](#4456))
([3ef9353](3ef9353)),
closes [#4400](#4400)
- correct typos in texts
([#4499](#4499))
([11fad59](11fad59))
- **landmark-unique:** follow spec, aside -> landmark
([#4469](#4469))
([e32f803](e32f803)),
closes [#4460](#4460)
- **required-attr:** allow aria-valuetext on slider instead of valuenow
([#4518](#4518))
([135898b](135898b)),
closes [#4515](#4515)

This PR was opened by a robot 🤖 🎉
@Stanislav1975 Stanislav1975 mentioned this issue Aug 19, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this issue Sep 9, 2024
Open
@organich organich mentioned this issue Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WilcoFiers WilcoFiers

Labels
core Issues in the core code (lib/core) pr A pr has been created for the issue support
Projects
None yet
Milestone
Axe-core 4.10
1 participant
@WilcoFiers