Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure CircleCI is running on PRs coming from forks #497

Closed
WilcoFiers opened this issue Aug 22, 2017 · 5 comments
Closed

Ensure CircleCI is running on PRs coming from forks #497

WilcoFiers opened this issue Aug 22, 2017 · 5 comments

Comments

@WilcoFiers
Copy link
Contributor

This PR never got tested. It seems to be because it's from a fork, but we need to figure it out.
#492

@marcysutton
Copy link
Contributor

I found out a little more information: https://twitter.com/shawnbot/status/907302027692089345

It's a security measure—If your CI configuration includes private or encrypted environment variables, they could be compromised by the fork.

Trying to determine if there's a safe workflow, given that we have no environment variables as far as I can tell.

@marcysutton
Copy link
Contributor

Found the setting, you have to enable it in CircleCI Settings.

@WilcoFiers
Copy link
Contributor Author

Nice!

@WilcoFiers
Copy link
Contributor Author

@marcysutton can you make the same changes to our other open source projects?

@marcysutton
Copy link
Contributor

marcysutton commented Sep 17, 2017 via email

mrtnvh pushed a commit to mrtnvh/axe-core that referenced this issue Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants