fix(get-background-color): scroll element into view horizontally #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmathieson
previously approved these changes
Oct 14, 2019
stephenmathieson
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In IE11
scrollIntoViewdoes not accept an options parameter, so will treat any truthy value as passing the booleantrue. This changes the behavior of the code that's currently there.So instead we'll just see if the center point of the element is within the viewport and if not, look for a scrollable parent element and scroll it. Should fix the issue without causing any problems in IE11.
Closes issue: #1730
Reviewer checks
Required fields, to be filled out by PR reviewer(s)