Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use lts-browsers for nightly tests #3269

Merged
merged 16 commits into from
Nov 10, 2021
Merged

ci: use lts-browsers for nightly tests #3269

merged 16 commits into from
Nov 10, 2021

Conversation

straker
Copy link
Contributor

@straker straker commented Nov 9, 2021

Also updated the image syntax for our normal runs.

See https://circleci.com/developer/images/image/cimg/node

@straker straker requested a review from a team as a code owner November 9, 2021 20:40
michael-siek
michael-siek previously approved these changes Nov 10, 2021
Copy link
Member

@michael-siek michael-siek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilcoFiers
Copy link
Contributor

I'm not sure what this does, but I trust Michael's review on this.

@straker
Copy link
Contributor Author

straker commented Nov 10, 2021

Finally got it working to correctly run nightly browsers of Chrome and Firefox!

See https://app.circleci.com/pipelines/github/dequelabs/axe-core/3071/workflows/abf894e1-b9d4-44fc-95bc-37482cd113a1/jobs/38389 (notice it's using Chrome and Firefox 96)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants