-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): v4.6.0 #3824
Merged
Merged
chore(release): v4.6.0 #3824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: merge master into develop
…valuenow on focusable separator (#3786) * feat(aria-required-attr): require aria-controls on combobox and aria-valuenow on focusable separator * integration tests
…3784) * feat(list,listitem): do not allow group as allowed parent or child * fix tests
…-like roles (#3785) Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* fix(metadata): Map aria-required-children to ACT rule bc4a75 * Update rule-desc
* fix(context): Allow multiple strings for include/exclude * Complete refactor
* feat(utils): new shadowSelectAll utility * Apply suggestions from code review Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
…-color (#3791) * fix(color-contrast): use text-stroke colors * Use textStrokeEmMin option in contrast checks * address comment * Editorial * Update test/commons/color/get-foreground-color.js Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
…ox on input[type=button] (#3354) * Update allowed button & input type=button roles closes #3353 - Adds `role=combobox` to the `<button>` element. - Adds `role=combobox` and `role=checkbox` to the `<input type=button>` element. * fix whitespace * add pass ids * `button role=combobox` * `input type=button role=combobox` * `input type=button role=checkbox` * add tests * `button role=combobox` * `input type=button role=combobox` * `input type=button role=checkbox` Co-authored-by: Steven Lambert <steven.lambert@deque.com>
* Change html-lang-valid selector so the rule only applies when attrs have a value. Fix #3624 * add integration tests Co-authored-by: Steven Lambert <steven.lambert@deque.com>
…d option in favor of occurrenceThreshold to fix typo (#3782) * Correct typos of "occurrence" across axe-core. * Correct Markdown table spacing. * Add fix to accomodate previous typos to avoid breaking the API per WilcoFiers' suggestions. * Account for old spelling in subtreeText and minor formatting. * run tests * Add null-aware chaining where necessary. * run tests Co-authored-by: Steven Lambert <steven.lambert@deque.com>
* feat(context): allow scoping shadow DOM nodes * Refactor Context code * Code complete * cleanup * Fix tests * Update type definition * Write docs * Apply suggestions from code review Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> * Resolve comments * Add type definition tests * Apply suggestions from code review Co-authored-by: Erik Larsen <enlarsen@users.noreply.github.com> Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> * Update context.md * fix test * Update type test Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> Co-authored-by: Erik Larsen <enlarsen@users.noreply.github.com>
* chore: improve type definitions * Apply suggestions from code review Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
* ci: fix nightly test * add back filter
Co-authored-by: michael-siek <michael-siek@users.noreply.github.com>
* Update config.yml * Update config.yml
* ci: Add a workflow for creating releases Ref dequelabs/axe-api-team#304 * testing * all commits * push branch * pat * this repo still uses master * remove testing stuff * 🤖 Automated formatting fixes * Update .github/workflows/release.yml Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> * Update .github/workflows/release.yml Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> Co-authored-by: stephenmathieson <stephenmathieson@users.noreply.github.com> Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
…es with different size than their container (#3703) * fix(color-contrast): correctly calculate background color of text nodes with different size than their container * undo file rename * fix test * remove export * test name * comment * undeprecate for this pr * tests * fix test * fix firefox test * fix bug * firefox... * firefox ci is annoying * fix test? * new lint * sigh... * :P * :P * works now? * Update lib/commons/color/get-background-color.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update lib/commons/color/get-background-color.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update lib/commons/math/get-intersection-rect.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update lib/commons/math/get-intersection-rect.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update lib/commons/math/get-intersection-rect.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * changes * Update lib/commons/color/get-background-stack.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update lib/commons/color/get-background-color.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update lib/commons/dom/get-visible-text-rects.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * changes * 🤖 Automated formatting fixes * suggestions * suggestions * rename Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: straker <straker@users.noreply.github.com>
WilcoFiers
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.6.0 (2022-12-12)
Features
Bug Fixes
This PR was opened by a robot 🤖 🎉