Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rules): Change "alternate text" to "alternative text" #4582

Conversation

umut-gultekin
Copy link
Contributor

It should be alternative text, not alternate text.

Closes:

@umut-gultekin umut-gultekin requested a review from a team as a code owner September 19, 2024 17:07
@CLAassistant
Copy link

CLAassistant commented Sep 19, 2024

CLA assistant check
All committers have signed the CLA.

@straker
Copy link
Contributor

straker commented Sep 25, 2024

Thanks for the pr. It seems we've used the wording "alternate text" in several different rules. We agree that updating the wording to "alternative text" to match the HTML and ARIA specs would be good, but we'd like to do so consistently.

Would you mind updating all use-cases of the wording "alternate text" to "alternative text"? It looks like these rules are affected:

  • area-alt
  • image-alt
  • input-image-alt
  • object-alt
  • role-img-alt

@straker straker changed the title Correction of meaning on a single but important word on image-alt rule docs: Change "alternate text" to "alternative text" Oct 3, 2024
@straker
Copy link
Contributor

straker commented Oct 3, 2024

Thanks for the updates.

Approved for security.

@straker straker changed the title docs: Change "alternate text" to "alternative text" fix(rules): Change "alternate text" to "alternative text" Oct 3, 2024
@straker straker merged commit b03ada3 into dequelabs:develop Oct 3, 2024
20 of 23 checks passed
@umut-gultekin umut-gultekin deleted the improve-meaning-description-help-image-alt branch October 4, 2024 12:39
straker pushed a commit that referenced this pull request Oct 16, 2024
It should be alternative text, not alternate text. 

Closes:
@straker straker mentioned this pull request Oct 16, 2024
WilcoFiers added a commit that referenced this pull request Oct 16, 2024
###
[4.10.1](v4.10.0...v4.10.1)
(2024-10-16)

### Bug Fixes

- **aria-allowed-role:** add form to allowed roles of form element
([#4588](#4588))
([d462d67](d462d67)),
closes
[/github.com/dequelabs/axe-core/blob/develop/lib/standards/html-elms.js#L264](https://github.com/dequelabs//github.com/dequelabs/axe-core/blob/develop/lib/standards/html-elms.js/issues/L264)
- **axe.d.ts:** add typings for preload options object
([#4543](#4543))
([72e269f](72e269f))
- **button-name,input-button-name,input-img-alt:** allow label to give
accessible name
([#4607](#4607))
([364eb72](364eb72)),
closes [#4472](#4472)
[#3696](#3696)
[#3696](#3696)
- **get-ancestry:** add nth-child selector for multiple siblings of
shadow root ([#4606](#4606))
([bdd94a2](bdd94a2)),
closes [#4563](#4563)
- **rules:** Change "alternate text" to "alternative text"
([#4582](#4582))
([31e0f61](31e0f61))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants