Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dialog): ensure that dialogs are labelled by their heading #1260

Merged
merged 9 commits into from
Nov 14, 2023

Conversation

scurker
Copy link
Member

@scurker scurker commented Oct 20, 2023

closes #1259

@scurker scurker requested a review from a team as a code owner October 20, 2023 18:52
@scurker scurker requested a review from a team October 20, 2023 18:52
@github-actions
Copy link
Contributor

@thuey
Copy link
Collaborator

thuey commented Oct 23, 2023

Tests are failing. Otherwise, LGTM

@scurker
Copy link
Member Author

scurker commented Oct 23, 2023

Tests are failing. Otherwise, LGTM

Yup, there's a new axe-core check that's failing with a different modal that I'll need to fix.

…-aria-labelledby
@anastasialanz

This comment was marked as resolved.

@scurker scurker merged commit e08b517 into develop Nov 14, 2023
7 checks passed
@scurker scurker deleted the fix-dialog-heading-aria-labelledby branch November 14, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Associate Dialog Header with Dialog Title via aria-labelledby
3 participants