Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log marker is invisible on white background #2545

Closed
JakobEdding opened this issue Feb 19, 2024 · 0 comments · Fixed by #2546
Closed

Log marker is invisible on white background #2545

JakobEdding opened this issue Feb 19, 2024 · 0 comments · Fixed by #2546

Comments

@JakobEdding
Copy link
Contributor




Describe the bug
Marker lines added to the log view with m are invisible if the background color is white.

To Reproduce
Steps to reproduce the behavior:

  1. Configure k9s with skins/transparent.yaml
  2. Open k9s in a terminal window with white background color
  3. Open pod logs
  4. Hit m
  5. See that blank lines are added to the logs

Expected behavior
The marker color should match the views.logs.fgColor configured in the skin.

Screenshots
Marker is invisible on white background:
Screenshot 2024-02-19 at 22 35 21
Marker is visible on dark background:
Screenshot 2024-02-19 at 22 36 34

Versions (please complete the following information):

  • OS: macOS 14.3.1 (23D60)
  • K9s: v0.31.9
  • K8s: [e.g. 1.11.0]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use configured log fgColor to print log markers JakobEdding/k9s
1 participant
@JakobEdding