Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--auto-zoom is not updated when window size changed, and not applied for first image when --scale-down is enabled #244

Closed
infmagic2047 opened this issue Jun 12, 2016 · 1 comment · Fixed by #364

Comments

@infmagic2047
Copy link

infmagic2047 commented Jun 12, 2016

I'm not sure whether this is intended, but it looks like a bug to me.

The following patch fixes it for me, but also introduces some other problems:

diff -uNar feh-2.16/src/winwidget.c feh-2.16-new/src/winwidget.c
--- feh-2.16/src/winwidget.c    2016-06-09 15:02:41.000000000 +0800
+++ feh-2.16-new/src/winwidget.c    2016-06-12 22:16:50.703220494 +0800
@@ -424,7 +424,6 @@
        feh_draw_checks(winwid);

    if (!winwid->full_screen && opt.zoom_mode
-               && (winwid->zoom == 1.0) && ! (opt.geom_flags & (WidthValue | HeightValue))
                && (winwid->w > winwid->im_w) && (winwid->h > winwid->im_h))
        feh_calc_needed_zoom(&(winwid->zoom), winwid->im_w, winwid->im_h, winwid->w, winwid->h);

I don't know the correct way to fix it.

@Osndok
Copy link

Osndok commented Aug 12, 2017

I notice that specifying an initial "--geometry" works around this issue.... mostly... to re-zoom an image you would have to go forward-then-back to redraw the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants