Fix auto zoom on window resize #362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulteq
force-pushed
the
fix-auto-zoom
branch
4 times, most recently
from
b14c842 to
3c2ee3c
Compare
Simplifies the logic behind the automatic zoom ratio calculation, which is used by both `--auto-zoom` and `--scale-down`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the logic behind the automatic zoom ratio calculation, which is used by both
--auto-zoomand--scale-down.When merged this will:
wcommand when both--scale-downand--keep-zoom-vpare enabled--auto-zoomnot being triggered on window resize events when--scale-downis enabled--auto-zoomnot being applied to the first image--auto-zoomconflicting with manual zoomShould be merged after: #358 / #359 and #361
Fixes: #229
Fixes: #244
Found a better solution -> #364