Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4267 連合先からのメンションに対応 #4274

Merged
merged 7 commits into from
Sep 10, 2024

Conversation

nakkaa
Copy link
Member

@nakkaa nakkaa commented Sep 9, 2024

#4267 に対応します。

MISSKEY_FEDERATION がtrueの場合、連合先からのメンションに反応します。
falseの場合は、連合先からのメンションに対応せず、ローカルのメンションにのみ反応します。
規定値はfalseです。(過去のバージョンの挙動がfalse相当のため。)

nakkaa added a commit that referenced this pull request Sep 9, 2024
…di_flag

formatが間違ってたので直してあげたよ! #4274
nakkaa added a commit that referenced this pull request Sep 9, 2024
…di_flag

formatが間違ってたので直してあげたよ! #4274
massongit
massongit previously approved these changes Sep 9, 2024
Copy link
Member

@massongit massongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう。

run.py Outdated
host is None or host == conf.MISSKEY_DOMAIN
(conf.MISSKEY_FEDERATION)
or (
not conf.MISSKEY_FEDERATION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なくてもいいかなと思いつつも、あっておかしくなるわけではないのでヨシ。

@nakkaa
Copy link
Member Author

nakkaa commented Sep 9, 2024

boolだとうまく動かなくて死
多分文字列があれば何でもTrueと判定してそう。

nakkaa added a commit that referenced this pull request Sep 9, 2024
…di_flag

formatが間違ってたので直してあげたよ! #4274
@nakkaa nakkaa force-pushed the 4267_add_misskey_fedi_flag branch from c948577 to f7273a2 Compare September 9, 2024 15:51
@nakkaa nakkaa enabled auto-merge September 9, 2024 16:02
massongit
massongit previously approved these changes Sep 9, 2024
nakkaa added a commit that referenced this pull request Sep 9, 2024
…isskey_fedi_flag

formatが間違ってたので直してあげたよ! #4274
@nakkaa nakkaa requested a review from massongit September 10, 2024 00:31
@nakkaa nakkaa self-assigned this Sep 10, 2024
massongit
massongit previously approved these changes Sep 10, 2024
@nakkaa nakkaa force-pushed the 4267_add_misskey_fedi_flag branch from 8094077 to 009d3ff Compare September 10, 2024 17:19
@nakkaa nakkaa force-pushed the 4267_add_misskey_fedi_flag branch from 009d3ff to b1a2b74 Compare September 10, 2024 17:22
nakkaa added a commit that referenced this pull request Sep 10, 2024
…_fedi_flag

READMEを更新してあげたよ! #4274
nakkaa added a commit that referenced this pull request Sep 10, 2024
…di_flag

formatが間違ってたので直してあげたよ! #4274
@nakkaa nakkaa force-pushed the 4267_add_misskey_fedi_flag branch from b7a255f to 5ccdb67 Compare September 10, 2024 17:25
@nakkaa
Copy link
Member Author

nakkaa commented Sep 10, 2024

なんかmergeしようとしたらミスったのでマージ前にrevertする

…isskey_fedi_flag

formatが間違ってたので直してあげたよ! #4274
@nakkaa nakkaa merged commit e9d66ed into develop Sep 10, 2024
40 checks passed
@nakkaa nakkaa deleted the 4267_add_misskey_fedi_flag branch September 10, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants