Add apache library from core inspec as it was deprecated in inspec 4 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Pop <alexpop@users.noreply.github.com>
chris-rock
approved these changes
May 7, 2019
There was a problem hiding this comment.
@alexpop thank you very much! LGTM once green. Yes we can bump the release once merged.
Signed-off-by: Alex Pop <alexpop@users.noreply.github.com>
alexpop
force-pushed
the
ap/add-apache-resource
branch
from
66aeae5
to
7008435
Compare
|
Thanks Chris. It's green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
apacheresource used by this profile has been deprecated in InSpec 4In this PR, I copied the resource from InSpec and removed the deprecation call from
initialize.If this gets merged, is it ok to bump the profile version to 2.1.0 and release it?