Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed trailing slashes in 1.8, 1.9 #63

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Removed trailing slashes in 1.8, 1.9 #63

merged 1 commit into from
Nov 13, 2019

Conversation

presidenten
Copy link
Contributor

@presidenten presidenten commented Nov 12, 2019

Benchmark tests 1.8 and 1.9 had trailing slashes and would thus never pass since auditctl -l removes trailing slashes.

Also compared with the pdf from cis-benchmarks, and they also do not have trailing slashes:
image

image

@presidenten presidenten changed the title Removed trailing slash Removed trailing slashes in 1.8, 1.9 Nov 12, 2019
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @presidenten for this fix and your first time-contribution to dev-sec 👍

Once you signed-off your commit, I am happy to merge it.

Signed-off-by: Johan Hernefeldt <johan.hernefeldt@teliacompany.com>
@presidenten
Copy link
Contributor Author

Thank you @presidenten for this fix and your first time-contribution to dev-sec 👍

Once you signed-off your commit, I am happy to merge it.

@chris-rock
Never done that before, but everything has a first time :-)

On a side note, I made a custom reporter for your benchmarks. You should check it out, its kind of neat. :-) Im telling you here since I have no clue how to reach you guys.
https://github.com/presidenten/cis-benchmark-allure-reporter
I packaged it into a docker image for easy use:
https://hub.docker.com/r/presidenten/cis-benchmark-allure-reporter

I also prepacked the devsec benchmarks into its own docker image to lock versions so it can easily be run everywhere.
It will be updated soon though with some more configurability.
https://github.com/presidenten/dev-sec-cis-benchmarks
https://hub.docker.com/r/presidenten/dev-sec-cis-benchmarks

@chris-rock
Copy link
Member

Thank you. It looks really great. We retweeted your tweet already. You can always reach us via the mailing list too https://dev-sec.io/community/

@chris-rock chris-rock merged commit dcdcf34 into dev-sec:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants