login.defs.erb: set LOG_OK_LOGINS = "no", correct ENV_PATH syntax #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOG_OK_LOGINS is set to "no" by default in Debian which is the upstream source of this template. All values should be default unless they can be configured by the module. Add separator for ENV_PATH otherwise the first value in "additional_user_paths" will not be separated from the default value in the file.
|
@3flex Awesome, thank you for noticing both! 👍 |
arlimus
added a commit
that referenced
this pull request
Aug 11, 2014
login.defs.erb: set LOG_OK_LOGINS = "no", correct ENV_PATH syntax
|
Added trello ticket as follow-up to OS differences in login.defs: https://trello.com/c/4AJlP5H4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LOG_OK_LOGINS is set to "no" by default in Debian which appears to be the upstream source of this template. All values should be default unless they can be configured by the module.
Add separator for ENV_PATH otherwise the first value in "additional_user_paths" will not be separated from the default value in the file.