use latest typescript and fix issue with importHelpers #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense! I'll merge this and include it in today's release. Do you think it's worth moving to |
|
Great! I actually already tried that plugin first time round, but it has some issues of its own relating to parallel cache directories conflicting, see here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the rollup plugin to use the latest version of Typescript, since it currently uses an ancient version
This also fixes an issue where the helpers imported are not transpiled properly
rollup/rollup-plugin-typescript#106
I found this issue when trying to use microbundle to package up a lib that uses the spread operator and fails hard on uglify, since there is a rogue
constinserted improperlyObviously it would be better if this were fixed upstream, (there is a PR for it) but it's a ghost town over there, hence the many forks of the plugin.