remove incomplete inputs from span attributes, add logging

Author: hrodmn

src/titiler/core/titiler/core/factory.py

@@ -873,12 +873,11 @@ def tile(
         ):
             """Create map tile from a dataset."""
             tms = self.supported_tms.get(tileMatrixSetId)
-            logger.info("opening dataset")
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(
                     src_path, tms=tms, **reader_params.as_dict()
                 ) as src_dst:
-                    logger.info("reading data")
                     image = src_dst.tile(
                         x,
                         y,
@@ -888,10 +887,10 @@ def tile(
                         **layer_params.as_dict(),
                         **dataset_params.as_dict(),
                     )
-                    logger.info("reading data complete")
                     dst_colormap = getattr(src_dst, "colormap", None)
 
             if post_process:
+                logger.info("post-processing image")
                 image = post_process(image)
 
             content, media_type = self.render_func(
@@ -980,6 +979,7 @@ def tilejson(
 
             tms = self.supported_tms.get(tileMatrixSetId)
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(
                     src_path, tms=tms, **reader_params.as_dict()
                 ) as src_dst:
@@ -1140,6 +1140,7 @@ def wmts(
 
             tms = self.supported_tms.get(tileMatrixSetId)
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(
                     src_path, tms=tms, **reader_params.as_dict()
                 ) as src_dst:
@@ -1227,6 +1228,7 @@ def point(
         ):
             """Get Point value for a dataset."""
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     pts = src_dst.point(
                         lon,
@@ -1283,6 +1285,7 @@ def preview(
         ):
             """Create preview of a dataset."""
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     image = src_dst.preview(
                         **layer_params.as_dict(),
@@ -1346,6 +1349,7 @@ def bbox_image(
         ):
             """Create image from a bbox."""
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     image = src_dst.part(
                         [minx, miny, maxx, maxy],
@@ -1407,6 +1411,7 @@ def feature_image(
         ):
             """Create image from a geojson feature."""
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     image = src_dst.feature(
                         geojson.model_dump(exclude_none=True),
@@ -1478,6 +1483,7 @@ def info(
         ):
             """Return dataset's basic info or the list of available assets."""
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     return src_dst.info(**asset_params.as_dict())
 
@@ -1503,6 +1509,7 @@ def info_geojson(
         ):
             """Return dataset's basic info as a GeoJSON feature."""
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     bounds = src_dst.get_geographic_bounds(crs or WGS84_CRS)
                     geometry = bounds_to_geometry(bounds)
@@ -1527,6 +1534,7 @@ def available_assets(
         ):
             """Return a list of supported assets."""
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     return src_dst.assets
 
@@ -1560,6 +1568,7 @@ def asset_statistics(
         ):
             """Per Asset statistics"""
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     return src_dst.statistics(
                         **asset_params.as_dict(),
@@ -1597,6 +1606,7 @@ def statistics(
         ):
             """Merged assets statistics."""
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     # Default to all available assets
                     if not layer_params.assets and not layer_params.expression:
@@ -1653,6 +1663,7 @@ def geojson_statistics(
                 fc = FeatureCollection(type="FeatureCollection", features=[geojson])
 
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     # Default to all available assets
                     if not layer_params.assets and not layer_params.expression:
@@ -1729,6 +1740,7 @@ def info(
         ):
             """Return dataset's basic info."""
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     return src_dst.info(**bands_params.as_dict())
 
@@ -1754,6 +1766,7 @@ def info_geojson(
         ):
             """Return dataset's basic info as a GeoJSON feature."""
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     bounds = src_dst.get_geographic_bounds(crs or WGS84_CRS)
                     geometry = bounds_to_geometry(bounds)
@@ -1778,6 +1791,7 @@ def available_bands(
         ):
             """Return a list of supported bands."""
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     return src_dst.bands
 
@@ -1811,6 +1825,7 @@ def statistics(
         ):
             """Get Dataset statistics."""
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     # Default to all available bands
                     if not bands_params.bands and not bands_params.expression:
@@ -1867,6 +1882,7 @@ def geojson_statistics(
                 fc = FeatureCollection(type="FeatureCollection", features=[geojson])
 
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     # Default to all available bands
                     if not bands_params.bands and not bands_params.expression:

src/titiler/core/titiler/core/telemetry.py

@@ -96,26 +96,6 @@ def _get_span_name(op_name: str, factory_instance: Any) -> str:
     return f"{class_name}.{op_name}"
 
 
-def _extract_span_attributes(
-    sig: inspect.Signature, *args: Any, **kwargs: Any
-) -> Dict[str, Any]:
-    """Automatically extract primitive types from endpoint signature."""
-    try:
-        bound_args = sig.bind(*args, **kwargs)
-        bound_args.apply_defaults()
-        auto_attrs = {}
-        for key, value in bound_args.arguments.items():
-            if key in ("self", "request") or value is None:
-                continue
-            if hasattr(value, "value"):
-                value = value.value
-            if isinstance(value, (str, bool, int, float)):
-                auto_attrs[f"titiler.path_param.{key}"] = value
-        return auto_attrs
-    except Exception:
-        return {}
-
-
 def factory_trace(
     _func: Optional[Callable[P, Any]] = None,
     *,
@@ -128,15 +108,13 @@ def decorator(func: Callable[P, Any]) -> Callable[P, Any]:
             return func
 
         op_name = func.__name__
-        sig = inspect.signature(func)
 
         if inspect.iscoroutinefunction(func):
 
             @functools.wraps(func)
             async def async_wrapper(*args: P.args, **kwargs: P.kwargs) -> Any:
                 span_name = _get_span_name(op_name, factory_instance)
-                attributes = _extract_span_attributes(sig, *args, **kwargs)
-                with operation_tracer(span_name, attributes=attributes):
+                with operation_tracer(span_name):
                     return await func(*args, **kwargs)
 
             return async_wrapper
@@ -145,8 +123,7 @@ async def async_wrapper(*args: P.args, **kwargs: P.kwargs) -> Any:
             @functools.wraps(func)
             def sync_wrapper(*args: P.args, **kwargs: P.kwargs) -> Any:
                 span_name = _get_span_name(op_name, factory_instance)
-                attributes = _extract_span_attributes(sig, *args, **kwargs)
-                with operation_tracer(span_name, attributes=attributes):
+                with operation_tracer(span_name):
                     return func(*args, **kwargs)
 
             return sync_wrapper

src/titiler/mosaic/titiler/mosaic/factory.py

@@ -1,5 +1,6 @@
 """TiTiler.mosaic Router factories."""
 
+import logging
 import os
 from typing import Any, Callable, Dict, List, Literal, Optional, Set, Tuple, Type, Union
 from urllib.parse import urlencode
@@ -55,6 +56,8 @@
     "yes",
 ]
 
+logger = logging.getLogger(__name__)
+
 
 def PixelSelectionParams(
     pixel_selection: Annotated[  # type: ignore

src/titiler/xarray/titiler/xarray/factory.py

@@ -1,5 +1,6 @@
 """TiTiler.xarray factory."""
 
+import logging
 from typing import Any, Callable, Optional, Type, Union
 
 import rasterio
@@ -28,6 +29,8 @@
 from titiler.xarray.dependencies import DatasetParams, PartFeatureParams, XarrayParams
 from titiler.xarray.io import Reader
 
+logger = logging.getLogger(__name__)
+
 
 @define(kw_only=True)
 class TilerFactory(BaseTilerFactory):
@@ -84,6 +87,7 @@ def info_endpoint(
         ) -> Info:
             """Return dataset's basic info."""
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     info = src_dst.info().model_dump()
                     if show_times and "time" in src_dst.input.dims:
@@ -118,6 +122,7 @@ def info_geojson(
         ):
             """Return dataset's basic info as a GeoJSON feature."""
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     bounds = src_dst.get_geographic_bounds(crs or WGS84_CRS)
                     geometry = bounds_to_geometry(bounds)
@@ -175,6 +180,7 @@ def geojson_statistics(
                 fc = FeatureCollection(type="FeatureCollection", features=[geojson])
 
             with rasterio.Env(**env):
+                logger.info(f"opening data with reader: {self.reader}")
                 with self.reader(src_path, **reader_params.as_dict()) as src_dst:
                     for feature in fc.features:
                         shape = feature.model_dump(exclude_none=True)