-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port detection Optimization for Go Projects #38
Conversation
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 73.12% 73.16% +0.03%
==========================================
Files 11 11
Lines 1563 1565 +2
==========================================
+ Hits 1143 1145 +2
Misses 351 351
Partials 69 69 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it looks good to me. Left a minor suggestion and a comment :)
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good!
Few minor requests before merging:
Code needs rebase- Since this PR targets port detection optimizations for go projects, I'd rename it to "Port detection optimization for Go projects"
What does this PR do?
This PR improves the port detection process for Alizer, specifically for Go projects. Testing these changes against https://github.com/stackrox/stackrox resulted in a runtime speed increase of 50%. Within the PR the Go language has any file suffix with
_test.go
excluded from it's results, as well as addingmocks
andmigrations
to a list of excluded folders. This results in less files being required to search through.Which issue(s) does this PR fix
resolves devfile/api#1337
PR acceptance criteria
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer
Testing the speed of these changes can be done by importing the recognizer into a separate Go project and tracking the runtime. Unit tests have been added for the changes and can be viewed as part of
make test
.Issues Opened
Since the scope of this issue was primarily targeting Go, I have opened devfile/api#1376 to further the optimizations for all languages.