Skip to content

Commit 56712b0

Browse files
committed
Update proposal devfile
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
1 parent 462431e commit 56712b0

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

docs/proposals/console/devfile-import.md

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ metadata:
4040
name: nodejs
4141
version: 1.0.0
4242
attributes:
43-
alpha.build-dockerfile: https://raw.githubusercontent.com/odo-devfiles/registry/master/devfiles/nodejs/build/Dockerfile # can also be a path relative to the context
43+
alpha.build-dockerfile: ./mydir/Dockerfile # is a relative path to the context dir containing src files in the repo
4444
components:
4545
- name: myapplication
4646
attributes:
@@ -53,6 +53,20 @@ components:
5353
env:
5454
- name: FOO # set container env through the devfile.yaml for the container
5555
value: "bar"
56+
- name: otherapplication1
57+
container:
58+
image: someimage1
59+
endpoints:
60+
- name: http-3001
61+
- name: otherapplication2
62+
container:
63+
image: someimage2
64+
endpoints:
65+
- name: http-3002
66+
targetPort: 3002
67+
env:
68+
- name: ABC
69+
value: "xyz"
5670
```
5771
5872
Without the build guidance devfile spec, the proposed change here is to mention the dockerfile location in the metadata attribute. The attributes is a free form key-value pair and in the above example, a `alpha.build-dockerfile` key holds the dockerfile location; which would have otherwise been specified by the Dockerfile Build Guidance spec.

0 commit comments

Comments
 (0)