[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: apupier
Once this PR has been reviewed and has the lgtm label, please assign elsony for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Hi @apupier. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

On pto but was the original issue reported somewhere as user should not get an error for this.

On pto but was the original issue reported somewhere as user should not get an error for this.

reported quarkusio/quarkus#42058

Given that i wasn't reproducing outside of the devfile context I wasn't sure where is the root issue.

not a fan as fix happening and will make it not be so noisy.

If I understand well the fix, it will remain this message in log:

tools: ----------------------------
tools: --- Help improve Quarkus ---
tools: ----------------------------
tools: * Learn more: https://quarkus.io/usage/
tools: * Do you agree to contribute anonymous build time data to the Quarkus community? (y/n and enter) 
tools: [info] [Quarkus build analytics] Didn't receive a valid user's answer: `y` or `n`. The question will be asked again next time.

I feel like this will be nicer anyway to not have a this kind of log. It will also avoid to raise an exception which should gain few milliseconds.

afaik this is only issue in che for some reason it doesn't handle terminal/tty?

It is not only in Che context. Currently, it is when using odo and deploy on an OpenShift instance. Hich is something that can be used from local command-line, VS Code OpenShift toolkit, IntelliJ OpenShift extension; both locally or inside Che.