Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow Down Rate of Issuing Stale/Rotten Labels #1654

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

Jdubrick
Copy link
Contributor

Description of Changes

Summarize the changes you made as part of this pull request.

We have made a great deal of progress identifying and operating on the backlog of issues for Devfile. We are now ~100 issues and we should slow this process down as it is starting to reach very new issues.

Related Issue(s)

Link the GitHub/GitLab/JIRA issues that are related to this PR.

N/A

Acceptance Criteria

Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.

New testing and documentation issues can be opened under devfile/api/issues.

You can check the respective criteria below if either of the following is true:

  • There is a separate tracking issue opened and that issue is linked in this PR.
  • Testing/documentation updates are contained within this PR.

If criteria is left unchecked please provide an explanation why.

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.75%. Comparing base (0c95025) to head (ee0cb02).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1654   +/-   ##
=======================================
  Coverage   35.75%   35.75%           
=======================================
  Files          52       52           
  Lines        6696     6696           
=======================================
  Hits         2394     2394           
  Misses       4158     4158           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jdubrick Jdubrick requested a review from thepetk December 2, 2024 16:18
@thepetk
Copy link
Contributor

thepetk commented Dec 2, 2024

@Jdubrick needs DCO

Co-authored-by: Theofanis Petkos <thepetk@gmail.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@Jdubrick Jdubrick force-pushed the chore/reduce-stale-count branch from 2152c7e to 5fc592e Compare December 2, 2024 16:25
@Jdubrick
Copy link
Contributor Author

Jdubrick commented Dec 2, 2024

@Jdubrick needs DCO

pesky github doesn't sign off if I take your suggestion :( should be fixed now @thepetk

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jdubrick I forgot to add suggestion for the text

.github/workflows/stale.yaml Outdated Show resolved Hide resolved
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@Jdubrick Jdubrick requested a review from thepetk December 2, 2024 18:14
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jdubrick, thepetk

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick Jdubrick merged commit 52dcd5f into devfile:main Dec 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants