Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clo monitor exemption for release #143

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

Jdubrick
Copy link
Contributor

@Jdubrick Jdubrick commented Jan 12, 2024

All of the devfile repositories are currently being monitored on https://clomonitor.io/projects/cncf/devfile. As there are no releases planned for GitHub and the monitor is only tracking GitHub releases I am marking this as exempt on the monitor. The addition of the .clomonitor.yaml file allows this exemption to be properly tracked. Additionally it allows users who view the developer-images repo on the monitor to know that releases are going to quay.io.

fixes devfile/api#1388

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
.clomonitor.yaml Outdated
# Checks exemptions
exemptions:
- check: recent_release # Check identifier (see https://github.com/cncf/clomonitor/blob/main/docs/checks.md#exemptions)
reason: "There are no releases planned for GitHub. Releases for images are done on a rolling basis to quay.io."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could potentially be explicit here and state that Releases for images are done on a rolling basis to quay.io at quay.io/devfile/base-developer-image:ubi8-latest and quay.io/devfile/universal-developer-image:ubi8-latest.

Though this information is already present in the README and if we ever change the image tag we'd have to remember to update it here.

@svor @ibuziuk @l0rd WDYT?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can drop tags and just have Releases for images are done on a rolling basis to quay.io at quay.io/devfile/base-developer-image and quay.io/devfile/universal-developer-image.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svor +1 that sounds good to me.

@Jdubrick When you have a moment, can you please change the reasonfield to @svor's suggestion please? Then we can get this merged. Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AObuchow all done!

@AObuchow
Copy link
Contributor

LGTM, thank you for the PR @Jdubrick. Will wait for other feedback and then this should be good to merge.

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Jan 15, 2024
@openshift-ci openshift-ci bot added the lgtm label Jan 15, 2024
Copy link

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AObuchow, Jdubrick

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AObuchow AObuchow merged commit e7ca2f3 into devfile:main Jan 15, 2024
2 checks passed
@AObuchow
Copy link
Contributor

@Jdubrick thank you again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CNCF Cleaner Tasks for developer-images
3 participants