Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrecoverable sync errors are ignored in the DevWorkspaceRouting reconciler #1198

Closed
amisevsk opened this issue Oct 24, 2023 · 0 comments · Fixed by #1199
Closed

Unrecoverable sync errors are ignored in the DevWorkspaceRouting reconciler #1198

amisevsk opened this issue Oct 24, 2023 · 0 comments · Fixed by #1199
Assignees
Milestone

Comments

@amisevsk
Copy link
Collaborator

Description

The reconciler for DevWorkspaceRoutings ignores any UnrecoverableSyncErrors that come from the sync package, resulting in it attempting to reapply objects to the cluster despite e.g. a forbidden response coming from the API

How To Reproduce

  1. Create a resource quota specifying e.g. a maximum number of services in a namespace:
    apiVersion: v1
    kind: ResourceQuota
    metadata:
      name: resource-quota-services
    spec:
      hard:
        count/services: "1"
  2. Create two workspaces that have at least one endpoint (resulting in DWO attempting to create two services)
  3. Note that the second workspace remains stuck in the 'starting' state until it times out

Expected behavior

If the cluster tells us we're forbidden from doing something, we should respect that.

Additional context

Originally reported for the Eclipse Che project: eclipse-che/che#22068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant