-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DevfileRegistry CRD MemoryLimit field #76
Implement DevfileRegistry CRD MemoryLimit field #76
Conversation
@thepetk: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
This reverts commit 47dd095. Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
8a0f111
to
af35d66
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 25.30% 27.10% +1.80%
==========================================
Files 25 25
Lines 1415 1428 +13
==========================================
+ Hits 358 387 +29
+ Misses 1032 1020 -12
+ Partials 25 21 -4 ☔ View full report in Codecov by Sentry. |
bcdc09b
to
af35d66
Compare
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
/area registry-operator
What does does this PR do / why we need it:
This PR introduces the
MemoryLimit
resource field for theDevfileRegistrySpecContainer
- part of theDevfileRegistrySpec
.For each one of the
DevfileRegistrySpecContainer
included inside theDevfileRegistrySpec
(e.g.DevfileIndex
,OciRegistry
&RegistryViewer
) creates a getter function which assigns the default value in case the given value isnil
or invalid.New test cases have been added for the three getter functions.
Which issue(s) this PR fixes:
Fixes devfile/api#1428
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: