-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add override CRD fields #82
Add override CRD fields #82
Conversation
Skipping CI for Draft Pull Request. |
/test all |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
+ Coverage 27.03% 28.34% +1.30%
==========================================
Files 25 25
Lines 1435 1450 +15
==========================================
+ Hits 388 411 +23
+ Misses 1024 1018 -6
+ Partials 23 21 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
c2c86d3
to
13f81db
Compare
N/A to the issue. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* add override fields to DevfileRegistry CRD Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add override getters and defaults Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
Please specify the area for this PR
operator api
What does does this PR do / why we need it:
Adds override fields from the helm chart to the
DevfileRegistry
CRD:hostnameOverride
nameOverride
fullnameOverride
Which issue(s) this PR fixes:
Fixes #?
fixes devfile/api#1439
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: