Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add override CRD fields #82

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Mar 15, 2024

Please specify the area for this PR

operator api

What does does this PR do / why we need it:

Adds override fields from the helm chart to the DevfileRegistry CRD:

  • hostnameOverride
  • nameOverride
  • fullnameOverride

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#1439

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

  • Does the registry operator documentation need to be updated with your changes?

How to test changes / Special notes to the reviewer:

Copy link

openshift-ci bot commented Mar 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@michael-valdron michael-valdron changed the title Add override fields Add override CRD fields Mar 15, 2024
@michael-valdron
Copy link
Member Author

/test all

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.34%. Comparing base (bc2d8f4) to head (13f81db).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   27.03%   28.34%   +1.30%     
==========================================
  Files          25       25              
  Lines        1435     1450      +15     
==========================================
+ Hits          388      411      +23     
+ Misses       1024     1018       -6     
+ Partials       23       21       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-valdron michael-valdron marked this pull request as ready for review March 15, 2024 19:28
@openshift-ci openshift-ci bot requested review from elsony and johnmcollier March 15, 2024 19:28
@michael-valdron michael-valdron requested review from thepetk, Jdubrick and a team and removed request for johnmcollier and elsony March 15, 2024 19:29
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron michael-valdron force-pushed the feat/devfileregistry-crd-overrides branch from c2c86d3 to 13f81db Compare March 15, 2024 19:38
@michael-valdron
Copy link
Member Author

Does the registry operator documentation need to be updated with your changes?

N/A to the issue.

@michael-valdron
Copy link
Member Author

/retest

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 7b69290 into devfile:main Mar 18, 2024
11 checks passed
thepetk pushed a commit to thepetk/devfile-registry-operator that referenced this pull request Aug 20, 2024
* add override fields to DevfileRegistry CRD

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* add override getters and defaults

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

---------

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add helm chart override fields to DevfileRegistry registry operator CRD
2 participants